Post new reply

Thanks Dan,
That looks promising. I'll investigate later today.

I'm not in any sense a programmer. Will what is here help solve your iframe issue?

https://benmarshall.me/responsive-iframes/

Dan

Hi Roel,

Did you notice that the image on the final page displays another minor "bugette"!

When you open the initial "Edit Event" window for a series, the Title field background colour fills the whole line.

Whereas when you do not have edit rights and it is only the "Event" window that opens, the background colour only appears behind the text.

I think the Title field on both windows should appear as in the second "Event" window.

The site has a footer and because I haven't found a way of making the height of the iframe flexible so that the diary neatly fits the space allotted for it, and never has it's own scrollbar or an empty space below it, I was thinking about merging those static parts into the diary page.

I assumed the browser would load the static part from its cache, so there wouldn't be a big overhead.

However, learning how to make the iframe height vary with the content of diary would probably be preferable.

(I fear I'm drifting off topic!)

Why would you remove the iframe? When you put your page header in the calendar code, each time there a calendar update, you will have to re-integrate your page header.
A lot of web developers, including myself, don't like frames. but iframes are fine!

Thanks for your kind words about my diary. I'm sure my computer naive users will still find my Updater's Guide lacks some vital detail that seems obvious to us but doesn't occur to them.

My next big task is to remove the embedded iframe that I use for the calendar and try to incorporate my page header into your code! I'm putting that off to the new year!

I've inserted the patch you supplied and it seems to do the trick.

Yes, you found a bug Greg! Thanks or reporting this.
Same problem with September 2019. It is exactly the combination of the settings mentioned in your post both set to 1.

Easy fix: Edit the file views/month.php and change line 75
from . . .

  $sOffset = date("w",$tfDay) - $set['weekStart']; //offset first day

to . . .

  $sOffset = date("N",$tfDay) - $set['weekStart']; //offset first day (ISO)

Just the "w" should be replaced by an "N" in the date function (and ISO added to the comments at the end).
This fix will be included in the next calendar version, which I will release early 2019.

Roel

PS. I very much like the colors you have chosen for the different categories in the Church Diary; not too hard and not too soft, exactly right. I also read with interest your Updater's Guide, very clear explanation, I could not find any error