• Registered: 2018-03-25
  • Posts: 58

Topic: Time Picker - some more times to pick please

Hey,

It's just a little detail, but would be nice to have:
Lets say, on the Settings page the "Start and end hour in Day/Week view" is set to 8:00 to 22:00.
Then - if you try to pick the end time of an event from the time picker, the last entry is "21:45".
But we have indeed a lot of events with ending at 22:00.
So it would be nice to have this time in the picker too ...
But I don't want to show 23:00 in the day/week view - only to have the possibility to pick 22:00 in the time picker.

Greetings!

Quote Post 1

  • From: DK
  • Registered: 2018-03-02
  • Posts: 165

Re: Time Picker - some more times to pick please

Hello Stefan

I see what you mean.
You cannot in settings set the end time to e.g. 22:01 and then have the 22:00 to be in the "picker".

But you need not use the keyboard. When in day-view or week-view, you can "mark" the time-span you want, and if you mark from 20:00 to 22:00 then the start-time for the event will be set to 20:00 and the end-time to 22:00. But you will still have the "problem" in month-view.

I think it will not be complicated to have the time-picker include the last time from setting.

I think Roel could find a solution for this ( hopefully ) little "problem".

Schwartz's Website

Quote Post 2

  • Roel
  • Roel
  • Administrator
  • Offline
  • Registered: 2018-02-26
  • Posts: 565

Re: Time Picker - some more times to pick please

Hello Stefan & John,

Hmm . . . I could add one more line "22:00 22:15 22:30 22:45", but then I will have to make an exception for 24:00, because this is not a valid time (valid times: 00:00 - 23:59).
Is that  what you are looking for? Any thoughts, suggestions?

Roel

Quote Post 3

4 Reply by stefan (edited by stefan 2018-09-03 07:05:24)

  • Registered: 2018-03-25
  • Posts: 58

Re: Time Picker - some more times to pick please

Hello!

Well - I think no one would have something against another full line of times to pick ?!
Indeed this is what I already have done for us.
I just add a "+1" in the "common/dtpicker.js" in the "tPicker" Function on line 153. So now it is:

  for (var i=dwStartH; i<dwEndH+1; i++){

This has done it for me.
And yes - it will be used quite a lot in our calendar.

Stefan

PS But in this moment I think, I am wrong. Adding the "+1" is not a good Idea, when the last hour to show is set to 24 ... hmm

Quote Post 4

  • Roel
  • Roel
  • Administrator
  • Offline
  • Registered: 2018-02-26
  • Posts: 565

Re: Time Picker - some more times to pick please

Hello Stefan,

As long a you don't set the end time to 24:00 on the Settings page, it will work fine.
In the calendar source code I've changed it as follows.
File "common/dtpicker.js, line 153 . . .
from:

for (var i=dwStartH; i<dwEndH; i++){

to:

for (var i=dwStartH; i<=Math.min(dwEndH,23); i++){

So it will be included in the next calendar version.

Roel

Quote Post 5

  • Registered: 2018-03-25
  • Posts: 58

Re: Time Picker - some more times to pick please

Thanks for that!!!

Quote Post 6